Hi!
Thanks for your review!

We discussed offline about the patch, and I decided to make a review of it and 
fixes
up to your comments.


> 
> v2026-01-10-0001
> ================
> 
> 1.
> I'm pretty sure access/heaptoast.h is not needed by verify_nbtree.c.
> 

In fact this include is necessary because of line verify_common.c:236 which
uses TOAST_INDEX_TARGET


> 
> v2026-01-10-0002
> ================
> 
> blockNo is unsigned integer, so we should use %u in the format string.
> 
> The same goes for parentblkno — it should also use %u.
> 

Yes seems like there was misusage of format symbol.. I attached the v2026-01-12 
with
fixed symbol. Thanks!

--
Best regards,
Roman Khapov

Attachment: v2026-01-12-0001-Move-normalize-tuple-logic-from-nbtcheck.patch
Description: Binary data

Attachment: v2026-01-12-0002-Add-gist_index_check-function-to-verify-.patch
Description: Binary data


Reply via email to