On Fri, Jan 9, 2026 at 2:17 PM li carol <[email protected]> wrote:
> >On Wed, Jan 7, 2026 at 1:13 PM albert tan <[email protected]> > wrote: > >Hi Join, > >Thanks for pointing out extra issues. I have addressed them in v2. > > > > Hi Albert, John, > > > > In addition to the previous findings, I went through > src/backend/commands/extension.c again and identified other spots that need > adjustment for better clarity and grammar. > > In the header for find_in_paths: > > /* > > * Work in a very similar way with find_in_path but it receives an already > > * parsed List of paths to search the basename and it do not support macro > > * replacement or custom error messages (for simplicity). > > * > > * By "already parsed List of paths" this function expected that paths > already > > * have all macros replaced. > > */ > > > > This should be corrected to: > > "Works in a very similar way to find_in_path, but it receives an already > parsed List of paths to search the basename, and it does not support macro > replacement or custom error messages (for simplicity). By 'already parsed > List of paths' this function expects that the paths already have all macros > replaced." > > > > I hope this helps in making the file more consistent. > > > > Best regards, > > Yuan Li(carol) > Hi Carol, John Thanks for pointing out extra issues. I have addressed them in v3.
v3-0001-Correct-comment-wording-in-extension.c.patch
Description: Binary data
