Paul Guo <paul...@gmail.com> writes: > [ 0001-Fix-pg_upgrade-test-failure-caused-by-the-DDL-below.v2.patch ]
Actually, there's an even easier way to fix this, which is to discard the special case for BITOID/VARBITOID altogether, and let the "default" case handle it. Fixing things by removing code is always great when possible. Also, it's fairly customary to add a test case that actually exhibits the behavior you want to fix, so I added a regression test table that has some bit/varbit columns with defaults. I confirmed that that makes the pg_upgrade test fail without this ruleutils change. Pushed with those changes. regards, tom lane