Hi,
On Wed, Jan 07, 2026 at 12:35:08PM +0530, Soumya S Murali wrote:
> I agree with your point that the checkpoint completion message should
> use the same terminology as the starting message ( “fast” rather than
> “immediate”) and I have updated the patch accordingly and have
> attached herewith for review. This patch aligns the checkpoint
> completion log wording with the existing checkpoint starting message
> (using “fast” instead of “immediate”) for consistency.
First off, please send complete and not incremental patches.
From what I can tell, you currently also do not have "wal" as reason?
Also, you have "timed" vs "time" etc.
I think it would make most sense to factor out the logic for the
starting checkpoint reason from xlog.c ("(errmsg("checkpoint
starting:%s%s%s%s%s%s%s%s")") and use that both for starting and
stopping.
Michael