Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access)

[Andrey Borodin]

> On 6 Jan 2026, at 00:24, Melanie Plageman <melanieplage...@gmail.com> wrote:
> 
> <v32-0014-Pass-down-information-on-table-modification-to-s.patch>

I've tried to take an attempt to review some patches of this patchset. It's 
huge and mostly polished.

In a step "Pass down information on table modification to scan node" you pass 
SO_HINT_REL_READ_ONLY flag in IndexNext() and BitmapTableScanSetup(), but not 
in IndexNextWithReorder() and IndexOnlyNext(). Is there a reason why index 
scans with ordering cannot use on-access VM setting?

Also, comment about visibilitymap_set() says "Callers that log VM changes 
separately should use visibilitymap_set()" as if visibilitymap_set() is some 
other function.


Best regards, Andrey Borodin.