Hi, > > - dlist_node cache_elem; /* list member of per-catcache list */ > > + dlist_node cache_elem; /* list member of per-bucket list */ > > I'm not sure this is more informative. How about? > > dlist_node cache_elem; /* member for CatCache.cc_lbucket[] dlist */ > > I also really wonder what the fascination with having lower-case > struct names with camelCased typedef names in this file... It's not > really clear if that comment should say "CatCache.cc_lbucket[]" or > "catcache.cc_lbucket[]". I find the latter clearer so used that.
Your suggestion looks better, and we also need to update the comment of CatCTup.cache_elem. -- Regards, ChangAo Chen
