On Thursday, December 25, 2025 8:04 AM Fujii Masao <[email protected]> 
wrote:
> On Wed, Dec 24, 2025 at 4:28 PM Zhijie Hou (Fujitsu)
> <[email protected]> wrote:
> >
> > Hi,
> >
> > I noticed that the pg_rewind documentation still states that data
> > checksums is disabled by default, but it has been changed to on since PG18.
> >
> > Here's a small patch to update this.
> 
> Thanks for the patch!
> 
> -   the cluster was initialized with
> <application>initdb</application>.  Neither of these
> -   are currently on by default.  <xref linkend="guc-full-page-writes"/>
> -   must also be set to <literal>on</literal>, but is enabled by default.
> +   the cluster was initialized with <application>initdb</application>
> (the latter
> +   being the default).  <xref linkend="guc-full-page-writes"/> must also be 
> set
> +   to <literal>on</literal>, but is enabled by default.
> 
> Isn't "(the default)" enough here instead of "(the latter being the default)"?

Agreed. Here is the updated patch.

Best Regards,
Hou zj

Attachment: v2-0001-Fix-outdated-doc-in-pg_rewind.patch
Description: v2-0001-Fix-outdated-doc-in-pg_rewind.patch

Reply via email to