On Fri, Dec 19, 2025 at 6:13 AM Masahiko Sawada <[email protected]> wrote: > > > > > I've rebased the patch and addressed the review comments. > > Regards, >
Thanks for the patch. 1) + * There could be some transactions that might have started with the old + * status, but we don't need to wait for these transactions to complete as + * long as they valid XIDs. These transactions will appear in the they valid --> they have valid 2) + * One might think we need to wait for all running transactions, including + * read-only transactions, to finish before enabling logical decoding. Suggestion to change it slightly to make it more clear: One might think we need to wait for all running transactions, including those without XIDs and read-only ones, to finish before enabling logical decoding. ~~ Apart from the above trivial corrections, I have no more comments. I’ll conclude my review here; the patch LGTM. thanks Shveta
