On Wed, Dec 10, 2025 at 12:36:36PM -0600, Sami Imseih wrote: > .. and after giving this more thought, I actually don't think we should > do any validation for any of the callbacks. If an extension is writing > to any file ( core or custom ), naturally they will want to read it back. > Now I am not sure what these validations are protecting us against. > Also, maybe the extension wants to just read data from the main stats > file, I could see that use-case, perhaps. > > So, I am proposing removing the validation altogether. What do > you think?
The to and from callbacks are coupled with each other, so there may be a point in making sure that if one is defined so is the other. Now, I have never done any enforcement for the existing from/to serialization callbacks either because it would be quickly clear for one what needs to be done when implementing a custom kind. So I'd agree with just removing these checks and keep the code simpler. FWIW, I have begun putting my hands on your patch, editing it at some degree. I am not sure that I will be able to finish that today, but I'm working towards getting something done. -- Michael
signature.asc
Description: PGP signature
