> On Nov 28, 2025, at 16:16, Chao Li <[email protected]> wrote:
>
> Hi Hackers,
>
> While reviewing [1], it makes me recall an experience where I had a patch
> ready locally, but CommitFest CI failed with a shadows-variable warning. Now
> I understand that -Wall doesn't by default enable -Wshadows with some
> compilers like clang.
>
> I did a clean build with manually enabling -Wshadow and surprisingly found
> there are a lot of such warnings in the current code base, roughly ~200
> occurrences.
>
> As there are too many, I plan to fix them all in 3-4 rounds. For round 1
> patch, I'd see any objection, then decide if to proceed more rounds.
>
> [1]
> https://postgr.es/m/CAHut+PsF8R0Bt4J3c92+T2F0mun0rRfK=-gh+ibv2s-o8ah...@mail.gmail.com
>
CF entry added: https://commitfest.postgresql.org/patch/6262/
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
