From 9553785759d05c0cba05074ed08e0fb733cf4d19 Mon Sep 17 00:00:00 2001 From: Peter Smith Date: Fri, 28 Nov 2025 13:52:44 +1100 Subject: [PATCH v1] Fix shadow warning in subscriptioncmds.c --- src/backend/commands/subscriptioncmds.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/subscriptioncmds.c b/src/backend/commands/subscriptioncmds.c index 24b7023..8c856af 100644 --- a/src/backend/commands/subscriptioncmds.c +++ b/src/backend/commands/subscriptioncmds.c @@ -1122,10 +1122,10 @@ AlterSubscription_refresh(Subscription *sub, bool copy_data, * to be at the end because otherwise if there is an error while doing * the database operations we won't be able to rollback dropped slots. */ - foreach_ptr(SubRemoveRels, rel, sub_remove_rels) + foreach_ptr(SubRemoveRels, sub_remove_rel, sub_remove_rels) { - if (rel->state != SUBREL_STATE_READY && - rel->state != SUBREL_STATE_SYNCDONE) + if (sub_remove_rel->state != SUBREL_STATE_READY && + sub_remove_rel->state != SUBREL_STATE_SYNCDONE) { char syncslotname[NAMEDATALEN] = {0}; @@ -1139,7 +1139,7 @@ AlterSubscription_refresh(Subscription *sub, bool copy_data, * dropped slots and fail. For these reasons, we allow * missing_ok = true for the drop. */ - ReplicationSlotNameForTablesync(sub->oid, rel->relid, + ReplicationSlotNameForTablesync(sub->oid, sub_remove_rel->relid, syncslotname, sizeof(syncslotname)); ReplicationSlotDropAtPubNode(wrconn, syncslotname, true); } -- 1.8.3.1