> On 26 Nov 2025, at 12:11, Dagfinn Ilmari Mannsåker <[email protected]> wrote:
> This seems unrelated to the rest of the patch patch.
Yeah, I was working on a docs-patch in the same tree and only realized this
morning that I had accidentally included that part =)
>> diff --git a/src/tools/pgindent/pgperltidy b/src/tools/pgindent/pgperltidy
>> index 6af27d21d55..6fac758665a 100755
>> --- a/src/tools/pgindent/pgperltidy
>> +++ b/src/tools/pgindent/pgperltidy
>> @@ -7,6 +7,12 @@ set -e
>> # set this to override default perltidy program:
>> PERLTIDY=${PERLTIDY:-perltidy}
>>
>> +PERLTIDY_VERSION=20230309
>> +if ! $PERLTIDY -v | grep -q $PERLTIDY_VERSION; then
>> + echo "error: pgperltidy requires perltidy v$PERLTIDY_VERSION"
>
> I just realised, this message should really go to stderr, i.e. have >&2
> on the end.
Good point, I'll change that before committing and I'll also reword it to use
the same error as pgindent which has this:
"You do not appear to have $indent version $INDENT_VERSION installed on your
system.\n";
Consistency is good.
--
Daniel Gustafsson
