On Mon, Nov 24, 2025 at 1:00 PM Ashutosh Bapat <[email protected]> wrote: > > Hi Junwang, > > On Mon, Nov 24, 2025 at 8:01 AM Junwang Zhao <[email protected]> wrote: > > > > Hi Ashutosh, > > > > On Thu, Nov 20, 2025 at 11:01 PM Ashutosh Bapat > > <[email protected]> wrote: > > > > > > Hi Junwang, > > > > > > On Sun, Aug 31, 2025 at 4:35 PM Junwang Zhao <[email protected]> wrote: > > > > > > > > > > > > I have some review comments, and hope some of them are helpful. > > > > > > > > 1. > > > > > > > > doc/src/sgml/ddl.sgml > > > > > > > > +<programlisting> > > > > +CREATE PROPERTY GRAPH myshop > > > > + VERTEX TABLES ( > > > > + products LABEL product, > > > > + customers LABEL customer, > > > > + orders LABEL order > > > > + ) > > > > + EDGE TABLES ( > > > > + order_items SOURCE orders DESTINATION products LABEL contains, > > > > + customer_orders SOURCE customers DESTINATION orders LABEL has > > > > + ); > > > > +</programlisting> > > > > > > > > order is a reserved keyword, so the following example will fail, we > > > > should not give a wrong example in our document. > > > > > > > > > > I tried those examples and they all worked. What error are you > > > getting? What is not working for you? > > > > Here is what I got, pay attention to the queries with singular `order`, > > it's a > > reserved keyword. > > I see it now. Sorry for missing it earlier. > > I think something like attached should fix the problem, if we want to > continue with the current example. FWIW, it demos that quotes can be > used with labels, but we don't necessarily do that with other objects. > I am not sure whether Peter would like to continue with the example or > use a different one avoiding this subtlety altogether. Hence not > including it in the overall patchset. >
The patch WFM. Using a different one also works, maybe we can adopt part of the schema from LDBC SNB [1] [1] https://ldbcouncil.org/benchmarks/snb/ > > -- > Best Wishes, > Ashutosh Bapat -- Regards Junwang Zhao
