> On Nov 19, 2025, at 02:49, Melanie Plageman <[email protected]> wrote:
> 
> I no longer remember why I made that patch WIP, so I've removed that
> designation.

I just reviewed 0007. It removes the second parameter "bool skip_recently_used” 
 from SyncOneBuffer. The function is static and is only called in one place 
with skip_recently_used=true, thus removing the parameter seems reasonable, and 
without considering pinned buffer, the function is simplified a little bit.

I only got a tiny comment:
```
+                * We can make these check without taking the buffer content 
lock so
``` 

As you changed “this” to “these”, “check” should be changed to “checks” 
accordingly.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/






Reply via email to