On Wed, Nov 12, 2025 at 10:46:12AM +0530, Ashutosh Bapat wrote: > But C implementation uses ObjectIdGetDatum() where ObjectId is 32 bit integer. > values[4] = ObjectIdGetDatum(fctx->record[i].forknum); > > Since forknum values are within 16 bits and that's unlikely to change > in future, int2 seems to ok. Also casting it to a wider integer, OID, > also doesn't seem like a correctness issue. But it does look > inconsistent and a reader of C implementation may think that the SQL > datatype used is int4. Should we instead change the C Implementation > to be > > values[4] = Int16GetDatum((int16) fctx->record[i].forknum); > > The code has been there for 17 years, and I didn't find any previous > complaints. I propose to change just the master branch.
This just looks like a copy-pasto to me. Nice catch, will fix on HEAD. -- Michael
signature.asc
Description: PGP signature
