Thanks Andrew for the review. On Tue, 11 Nov 2025 at 20:41, Andrew Dunstan <[email protected]> wrote: > > > On 2025-11-11 Tu 12:59 AM, Mahendra Singh Thalor wrote: > > > > Hi, > > Here, I am attaching an updated patch for the review and testing. > > > > FIX: as suggested by Vaibhav, added error for --restrict-key option > > with non-text format. > > > > > Regarding the name and format of the globals toc file, I'm inclined to > think we should always use custom format, regardless of whether the > individual databases will be in custom, tar or directory formats, and > that it should be called something distinguishable, e.g. toc.glo. >
I also agree with your point. Fixed. On Mon, 17 Nov 2025 at 19:38, tushar <[email protected]> wrote: > > > > On Tue, Nov 11, 2025 at 11:29 AM Mahendra Singh Thalor <[email protected]> > wrote: >> >> On Thu, 6 Nov 2025 at 11:03, Mahendra Singh Thalor <[email protected]> >> wrote: >> > >> > Thanks Vaibhav, Tushar and Andrew for the review and testing. >> > > Thanks Mahendra, getting this error against v07 series patch > > [edb@1a1c15437e7c bin]$ ./pg_dumpall -Ft -f tar.dumpc -v > pg_dumpall: executing SELECT pg_catalog.set_config('search_path', '', false); > pg_dumpall: pg_dumpall.c:2256: createOneArchiveEntry: Assertion `fout != > ((void *)0)' failed. > Aborted > > regards, Thanks Tushar for the report. Fixed. Here, I am attaching an updated patch for the review and testing. -- Thanks and Regards Mahendra Singh Thalor EnterpriseDB: http://www.enterprisedb.com
v08_17112025-Non-text-modes-for-pg_dumpall-correspondingly-change.patch
Description: Binary data
