> On Nov 14, 2025, at 12:10, Chao Li <[email protected]> wrote:
>
> 21 - 0008 - ri_triggers.c
> ```
> + quoteOneName(attname,
> + RIAttName(fk_rel, riinfo->fk_attnums[i]));
> ```
>
> This patch uses quoteOneName() a lot. This function simply add double quotes
> without much checks which is unsafe. I think quote_identifier() is more
> preferred.
I looked further, and realized that quoteOneName() is widely used in
ri_triggers.c and the dest string are all defined as size of
MAX_QUOTED_REL_NAME_LEN.
So I take back comment 21.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
