Hi, I noticed that pg_logical_slot_get_changes_guts() assigns InvalidXLogRecPtr to the local variable upto_nchanges, even though it's not LSN variable (i.e., its type is int32, not XLogRecPtr). While this causes no functional issue since InvalidXLogRecPtr is defined as 0, it's semantically incorrect.
I propose fixing this by setting upto_nchanges to 0 instead of InvalidXLogRecPtr. Attached is a patch implementing this change. Regards, -- Fujii Masao
v1-0001-Fix-incorrect-assignment-of-InvalidXLogRecPtr-to-.patch
Description: Binary data
