On Tue, Nov 4, 2025 at 10:23 PM Álvaro Herrera <[email protected]> wrote: > > On 2025-Nov-04, Peter Smith wrote: > > > On Sat, Nov 1, 2025 at 5:02 AM Álvaro Herrera <[email protected]> wrote: > > > > I'm not opposed to 0001 (to master only), but I think the lines of > > > dashes are a little excessively noisy. Are there other opinions on > > > that? Note that vacuumlo also has it, with no dashes. > > > > It was intentionally "noisy" with dashes to make it impossible to > > accidentally overlook dry-run mode in the logs. But if that's contrary > > to the way Postgres does things I am fine if you want to remove the > > dashes. > > Yeah, I don't know if it's The Postgres Way or just accidental, but I'd > rather stay away from that kind of noise. Also, from a i18n point of > view, the lines of dashes (as implemented here) would get in the message > catalogs, which nobody will appreciate. Please do make the messages a > single string rather than two separate strings though, perhaps with an > embedded newline if more than one line of output is needed. >
Hi Alvaro, Here is patch v4-0001 modified as requested: - dashes are removed - the message is a single string ====== Kind Regards, Peter Smith. Fujitsu Australia
v4-0001-log-to-say-command-is-executing-in-dry-run-mode.patch
Description: Binary data
