After my analysis in the other subthread, patch 1 looks ready to be 
committed. Patch 2 looks good to go, but maybe you should split the "set 
-e" changes into a separate commit. Not sure how much I like patch 
3 since it hardcodes $libdir as "lib" for the purposes of finding the 
header, but it's also kind of a last resort thing, so ¯\_(ツ)_/¯. Maybe 
it's best if the meson build just copies whatever the autotools build 
does?

-- 
Tristan Partin
Databricks (https://databricks.com)


Reply via email to