On Wed, Aug 29, 2018 at 12:01 PM Alexander Korotkov <a.korot...@postgrespro.ru> wrote: > On Wed, Aug 29, 2018 at 5:05 AM Kyotaro HORIGUCHI > <horiguchi.kyot...@lab.ntt.co.jp> wrote: > > At Tue, 28 Aug 2018 18:50:31 +0300, Alexander Korotkov > > <a.korot...@postgrespro.ru> wrote in > > <capphfduqeyyjlxcnx_t7k2ugcdgvw7wlkl+zrfded5wzkvm...@mail.gmail.com> > > > Also I found that this new pg_ctl isn't covered with tests at all. So > > > I've added very simple tap tests, which ensures that when log file was > > > renamed, it reappeared again after pg_ctl logrotate. I wonder how > > > that would work on Windows. Thankfully commitfest.cputube.org have > > > Windows checking facility now. > > > > Thanks for the test. Documentaion and help message looks fine > > including the changed ordering. (180 seconds retry may be a bit > > too long but I'm fine with it.) > > Thank you for the comments. My idea about retry logic was to provide > the similar behavior to poll_query_until().
It seems that http://commitfest.cputube.org/ runs only "make check" on Windows. But my Postgres Pro colleagues checked that tests passed on 32-bit and 64-bit versions of Windows Server 2008. Also I made some minor beautifications on code and documentation. This patch seems to have good shape and generally being quite harmless. Do we have any objections to committing this? ------ Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company
pg_ctl_logrotate_v7.patch
Description: Binary data
