On Mon, 20 Oct 2025 at 21:43, David Rowley <[email protected]> wrote: > > On Mon, 20 Oct 2025 at 21:15, Michael Paquier <[email protected]> wrote: > > > > On Mon, Oct 20, 2025 at 05:46:33PM +1300, David Rowley wrote: > > @@ -5146,10 +5146,6 @@ ReorderBufferToastReplace(ReorderBuffer *rb, > > ReorderBufferTXN *txn, > > dlist_iter it; > > Size data_done = 0; > > > > - /* system columns aren't toasted */ > > - if (attr->attnum < 0) > > - continue; > > > > Er, why this removal?
> We don't put system attributes in TupleDescs so I put that check down > to misguided programming. Thank you for reviewing this. Now pushed. David
