On Wed, Oct 8, 2025 at 6:34 PM Peter Smith <[email protected]> wrote: > > Hi hackers, > > While reviewing pg_createsubscriber in another thread, I found some of > the current logging to be confusing. Specifically, there is one part > that drops all existing publications. Sometimes it might look like > this: > > ---------- > pg_createsubscriber: dropping all existing publications in database "db2" > pg_createsubscriber: dropping publication "pub_exists1" in database "db2" > pg_createsubscriber: dropping publication "pub_exists2" in database "db2" > pg_createsubscriber: dropping publication "pub_exists3" in database "db2" > ---------- > > ~~~ > > OTOH, if there is nothing found to be dropped, then the logging just says: > > ---------- > pg_createsubscriber: dropping all existing publications in database "db2" > ---------- > > That's the scenario that I found ambiguous. You can't be sure from the > logs what happened: > - Were there publications found, and were they dropped silently? > - Did it not find anything to drop? > > ~~~ > > Here is a small patch to remove that doubt. Now, if there is nothing > found, the logging would look like: > > ---------- > pg_createsubscriber: dropping all existing publications in database "db2" > pg_createsubscriber: no publications found > ---------- > > Thoughts?
Thank you for the patch! It sounds like a reasonable improvement. I'll push the patch, barring any objections. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
