On 02.10.25 23:31, Nathan Bossart wrote:
On Thu, Oct 02, 2025 at 05:08:42PM -0400, Tom Lane wrote:
Nathan Bossart<[email protected]> writes:
The benefit is that we can safely assume little-endian in AAarch64-specific
code, and on the off-chance that someone tries to build Postgres in an
AArch64/big-endian environment, we aren't pretending to support it.
Is that actually a meaningful benefit, ie can we remove any code
anywhere?
I'm not aware of existing code that is broken, but some of the stuff I'm
intending to commit soon to optimize hex_{encode,decode} might be sensitive
to endianness. In any case, I don't think it's outside the realm of
possibilities for architecture-specific code.
As a future direction, in cases like this I think it would be better to
write a static assertion. Then the check is self-contained in the C
code, perhaps next to the code it's trying to protect, perhaps with a
comment, and doesn't have to be maintained in some far-away configure
shell script.
