On Fri, Sep 26, 2025 at 8:14 PM shveta malik <[email protected]> wrote: > > > It seems it is missed to be changed perhaps due to bringing back > previous implementation of slotsync_api_reread_config() > > > > > > b) > > > There is double space in DETAIL msg: "have changed since" > > > > > > Will it be better to shorten the DETAIL as: 'One or more of > > > primary_conninfo, primary_slot_name, or hot_standby_feedback were > > > modified.' > > > > > > > Changed. > >
Fixed. > > This too is missed. > > > > 6) > > > postgres=# SELECT pg_sync_replication_slots(); > > > ERROR: exiting from slot synchronization as promotion is triggered > > > > > > Shall we rephrase it similar to the previous message: 'cannot continue > > > replication slots synchronization as standby promotion is triggered' > > > > > Changed. > > > > Attaching patch v14 incorporating the above changes. > > > This was rephrased. > Few trivial comments: > > 1) > slotsync_api_reread_config(): > + * Returns true if conninfo, primary_slot_name or hot_standby_feedback > changed. > > This comment is no longer valid, we can remove it. > Removed. > 2) > /* We are done with sync, so reset sync flag */ > reset_syncing_flag(); > + > > This extra blank line is not needed. Fixed. Attaching patch v15 addressing these comments. regards, Ajin Cherian Fujitsu Australia
v15-0001-Improve-initial-slot-synchronization-in-pg_sync_.patch
Description: Binary data
