Hi, Andrei! On Tue, Aug 12, 2025 at 12:40 PM Andrei Lepikhov <lepi...@gmail.com> wrote: > On 11/8/2025 20:15, Greg Sabino Mullane wrote: > > I'm not convinced this is an improvement from someone just coming in to > > this part of the code, especially given (for example) the comment right > > above it: > > > > * Determine if the inner table can duplicate outer rows. We must > > * bypass the unique rel cache here since we're possibly using aThanks for > > your feedback. > I made some minor adjustments to the comments to make the code more > consistent. Sure, rrel and krel don't seem like the best solution - I > guess natives could find less wordy synonyms than just dumb > 'keeping_rel' and 'removing_rel'. But it is simpler to track which > relation and RowMark should be removed.
Thank you for catching this. And thank you for the fix. I think it worth separating fix and refactoring. This helps to understand what exactly the fix is by looking at the patch. I also edited commit message. I'm going to push this if no objections. ------ Regards, Alexander Korotkov Supabase
v2-0001-Refactor-variable-names-in-remove_self_joins_one_.patch
Description: Binary data
v2-0002-Improve-RowMark-handling-during-Self-Join-Elimina.patch
Description: Binary data
