Dear Doruk, > That sounds reasonable. I’ve updated the patch and added more > information to the documentation covering the topics you mentioned. > I also added a Caution block so potential users won’t miss it. I hope > this patch meets your expectations.
Can you explain more why we must extend the SQL interface? I read your use case [1], and looks like that a new type of background worker is introduced in your system. If so, why doesn't the worker directly call C-lang interface replorigin_session_setup()? Personally considered, SQL functions are usable by unfamiliar users so that this change may be dangerous. It is better if developers can use C APIs instead. [1]: https://www.postgresql.org/message-id/CAMPB6wckvkKrXVPH5j8Ske2cVedkb-TRLdnOb5e74zYM1CynGw%40mail.gmail.com Best regards, Hayato Kuroda FUJITSU LIMITED
