On Tue, Aug 19, 2025 at 2:28 PM Tom Lane <t...@sss.pgh.pa.us> wrote:
> You'll presumably have to use GetMemoryChunkContext() for RelOptInfo,
> so I don't see much downside from using it in one or even both of the
> other cases too.

Pointer dereference must be faster than a function call.

> Hm.  We don't have read support for these structs, so maybe it's fine.
> It looks weird though.

Left this one as-is for now.

Here's v2. 0001 is what you saw before with an attempt to fix the
memory context handling. 0002 removes join_search_private. All I've
tested is that the tests pass.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Attachment: v2-0002-Remove-PlannerInfo-s-join_search_private-method.patch
Description: Binary data

Attachment: v2-0001-Allow-private-state-in-certain-planner-data-struc.patch
Description: Binary data

Reply via email to