Hi hackers, While reviewing [1], I noticed a useless pointer advance and saw that StatsShmemInit() is doing the same.
As StatsShmemInit() is existing code, let's fix it: the pointer is not used after its last advance, so that advance is unnecessary and can be removed. [1]: https://www.postgresql.org/message-id/CAA5RZ0ukmNd%2BC1jH4V6BGEea-wmyLxDtDE5QoEtfXd2W5HNHfQ%40mail.gmail.com Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
>From b8f56fe7df72830b0054c3652170716341d9dee2 Mon Sep 17 00:00:00 2001 From: Bertrand Drouvot <bertranddrouvot...@gmail.com> Date: Mon, 18 Aug 2025 08:22:27 +0000 Subject: [PATCH v1] Remove useless pointer advance in StatsShmemInit() A pointer is not used after its last advance, so that advance is unnecessary and can be removed. --- src/backend/utils/activity/pgstat_shmem.c | 1 - 1 file changed, 1 deletion(-) 100.0% src/backend/utils/activity/ diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c index cca4277f234..62de3474453 100644 --- a/src/backend/utils/activity/pgstat_shmem.c +++ b/src/backend/utils/activity/pgstat_shmem.c @@ -180,7 +180,6 @@ StatsShmemInit(void) * provides a small efficiency win. */ ctl->raw_dsa_area = p; - p += MAXALIGN(pgstat_dsa_init_size()); dsa = dsa_create_in_place(ctl->raw_dsa_area, pgstat_dsa_init_size(), LWTRANCHE_PGSTATS_DSA, NULL); -- 2.34.1
