Hi, On Wed, Aug 13, 2025 at 5:44 PM kasaharatt <kasahar...@oss.nttdata.com> wrote:
> >>>> > Approach 2: > >>>> > - log_autovacuum_min_duration: Changed behavior, which controls only > >>>> > autovacuum logging. > >>>> > - log_autoanalyze_min_duration: New parameter, which controls > >>>> > autoanalyze logging. > >>>> > >>>> My vote is for this approach. It is probably OK to change the > >>>> behavior of > >>>> log_autovacuum_min_duration, as the new GUC will have the same > >>>> default > >>>> value. > >>> > >>> > >>> Thank you for voting. I also think this approach is reasonable to > >>> implement. > >> > >> > >> A new patch is attached. > >> Thoughts? > I reviewed this patch. > I also have no particular objections to the Approach 2. Thank you for the review! > > + <term><literal>log_autoanalyze_min_duration</literal>, > > <literal>toast.log_autoanalyze_min_duration</literal>(<type>integer</type>) > (snip) > > + "toast.log_autoanalyze_min_duration", > This patch adds the log_autoanalyze_min_duration parameter fot TOAST > tables. > However since PostgreSQL currently does not support ANALYZE on TOAST > tables, > isn't this parameter unnecessary? You're right; that was a mistake. I've fixed it in the v4 patch. +log_autoanalyze_min_duration = 0 Additionally, I removed the above setting from the test files in src/test/modules/xid_wraparound/t/ (001_emergency_vacuum.pl, 002_limits.pl, 003_wraparounds.pl). The reason is that these tests check for autovacuum logs, not autoanalyze logs. You can run the test with the following command: make check -C src/test/modules/xid_wraparound PG_TEST_EXTRA='xid_wraparound' -- Best regards, Shinya Kato NTT OSS Center
v4-0001-Add-log_autoanalyze_min_duration.patch
Description: Binary data
