On Mon, Aug 04, 2025 at 02:37:19PM -0500, Jim Nasby wrote: > On Fri, Aug 1, 2025 at 4:03 AM Michael Paquier <mich...@paquier.xyz> wrote: >> - Addition of separate patch to rename varatt_external to >> varatt_external_oid and VARTAG_ONDISK to VARTAG_ONDISK_OID, in 0003. > > Since you're already renaming things... ISTM "ondisk" has the potential for > confusion, assuming that at some point we'll have the ability to store > large datums directly in the filesystem (instead of breaking into chunks to > live in a relation). VARTAG_DURABLE might be a better option.
Hmm. I don't know about this one. Durable is an ACID property that does not apply to all relation kinds. For example, take an unlogged table: its data is not durable but its TOAST pointers would be marked with a VARTAG_DURABLE. With that in mind ONDISK still sounds kind of OK for me to use as a name. -- Michael
signature.asc
Description: PGP signature
