Hello,
On 2025-Apr-04, Andres Freund wrote:
> FWIW, with cassert and -O2, it's:
>
> 17:
> real 0m53.981s
> user 3m22.837s
> sys 3m24.237s
>
> HEAD:
> real 1m19.749s
> user 4m54.526s
> sys 4m15.657s
>
> so this isn't just due to me using -O0. A 48% increase is better than a 60%
> increase, but it's still not sustainable.
I happened to notice that this item was still open in the commitfest,
and rereading the thread I now have second thoughts about having it
enabled by default, giving your complaints about speed. How about
applying this to 18 and master?
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"This is a foot just waiting to be shot" (Andrew Dunstan)
>From f50d28ceba7d98672f16bf5049203ae9745871f8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=81lvaro=20Herrera?= <alvhe...@kurilemu.de>
Date: Tue, 5 Aug 2025 16:32:16 +0200
Subject: [PATCH] Skip expensive pg_upgrade test unless PG_TEST_EXTRA
---
src/bin/pg_upgrade/t/002_pg_upgrade.pl | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/bin/pg_upgrade/t/002_pg_upgrade.pl b/src/bin/pg_upgrade/t/002_pg_upgrade.pl
index 7d82593879d..5afa6fdfe94 100644
--- a/src/bin/pg_upgrade/t/002_pg_upgrade.pl
+++ b/src/bin/pg_upgrade/t/002_pg_upgrade.pl
@@ -375,6 +375,8 @@ SKIP:
{
my $dstnode = PostgreSQL::Test::Cluster->new('dst_node');
+ skip "not enabled in PG_TEST_EXTRA"
+ if (!$ENV{PG_TEST_EXTRA} || $ENV{PG_TEST_EXTRA} !~ /\bregress_dump_upgrade\b/);
skip "different Postgres versions"
if ($oldnode->pg_version != $dstnode->pg_version);
skip "source node not using default install"
--
2.39.5
