On Tue, Jul 22, 2025 at 2:42 AM Shinya Kato <shinya11.k...@gmail.com> wrote: > > On Tue, Jul 22, 2025 at 6:06 PM Yugo Nagata <nag...@sraoss.co.jp> wrote: > > > > On Tue, 22 Jul 2025 17:48:35 +0900 > > Shinya Kato <shinya11.k...@gmail.com> wrote: > > > > > Hi hackers, > > > > > > Starting with PostgreSQL 17, pg_basebackup supports incremental > > > backups. However, the pg_stat_progress_basebackup view doesn't > > > currently show the backup type (i.e., whether it's a full or > > > incremental backup). > > > > > > Therefore, I propose adding a backup_type column to this view. While > > > this information is available in pg_stat_activity, the backup type is > > > important for monitoring the progress of pg_basebackup, and including > > > it directly in the progress view would be very useful. > > > > > > Thoughts? > > > > That seems reasonable to me.
I like this idea. > Thank you for the review. > I made a careless mistake. Fixed. The patch seems reasonably simple and looks good to me. I've updated the comment in bbsink_progress_new() and attached the modified version patch (with the commit message). Please review it. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
v3-0001-Add-backup_type-column-to-pg_stat_progress_baseba.patch
Description: Binary data
