> On Thu, Jul 31, 2025 at 11:03 AM Tatsuo Ishii <is...@postgresql.org> wrote: >> > Yes. When an error occurs and an error response message returned from >> > backend, pgbench will send one more sync message, then sends ROLLBACK >> > if necessary. I think the code above should be changed to call >> > PQgetResult repeatably until it returns NULL. > > I was thinking the same. The attached patch implements that approach, > and it seems to eliminate the assertion failure.
The patch looks good to me and I confirmed it fixes the the assertion failure. >> Correction. That would not be a proper fix. Just removing inner >> PQgetResult and the Assert is enough? > > Could you explain why you think repeatedly calling PQgetResult > until it returns NULL isn't the right fix? Sorry, that was my thinko. I should have had more coffee. -- Tatsuo Ishii SRA OSS K.K. English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp
