On Thu, Jul 24, 2025 at 6:46 PM shveta malik <shveta.ma...@gmail.com> wrote: > Sounds reasonable. > Thinking out loud, when cleaning up after a backend or background > worker crash, process_pm_child_exit() is invoked, which subsequently > calls both CleanupBackend() and HandleChildCrash(). After the cleanup > completes, process_pm_child_exit() calls PostmasterStateMachine() to > move to the next state. As part of that, PostmasterStateMachine() > invokes ResetBackgroundWorkerCrashTimes() (only in crash > scenarios/FatalError), to reset a few things. Since it also resets > rw_worker.bgw_notify_pid, it seems reasonable to reset the rw_pid as > well there.
Thanks! Attached is a patch that fixes the issue by resetting rw_pid in ResetBackgroundWorkerCrashTimes(). We should probably add a regression test for this case, but I'd prefer to commit the fix first and work on the test separately. Andrey Rudometov proposed a test patch in thread [1], which we might use as a starting point. Regards, [1] https://postgr.es/m/CAF6JsWiO=i24qyitwe6ns1sxqcl86ryxdyu+pnyk-wuekps...@mail.gmail.com -- Fujii Masao
v2-0001-Fix-background-worker-not-restarting-after-crash-.patch
Description: Binary data
