On Tue, Jul 22, 2025 at 9:30 PM Andrei Lepikhov <lepi...@gmail.com> wrote: > > On 22/7/2025 07:22, Fujii Masao wrote: > > Log remote NOTICE, WARNING, and similar messages using ereport(). > > > > Previously, NOTICE, WARNING, and similar messages received from remote > > servers over replication, postgres_fdw, or dblink connections were printed > > directly to stderr on the local server (e.g., the subscriber). As a result, > > these messages lacked log prefixes (e.g., timestamp), making them harder > > to trace and correlate with other log entries. > > > > This commit addresses the issue by introducing a custom notice receiver > > for replication, postgres_fdw, and dblink connections. These messages > > are now logged via ereport(), ensuring they appear in the logs with proper > > formatting and context, which improves clarity and aids in debugging. > Perhaps I'm wrong, but it seems to me that you also need to add the > libintl link to the Makefile of each module that uses the > libpqsrv_notice_receiver routine. > At least, without this patch, I can't build master under MacOS: > > Undefined symbols for architecture x86_64: > "_libintl_gettext", referenced from: > _libpqsrv_notice_receiver in dblink.o > ld: symbol(s) not found for architecture x86_64 > clang: error: linker command failed with exit code 1 (use -v to see > invocation)
This issue is currently being discussed in thread [1]. The consensus there is to remove the translation-related changes (like the translation marker) introduced by the original commit to resolve the problem. Regards, [1] https://postgr.es/m/0e6299d9-608a-4ffa-aeb1-40cb8a990...@oss.nttdata.com -- Fujii Masao
