On Thu, Jul 17, 2025 at 1:41 AM Dagfinn Ilmari Mannsåker <ilm...@ilmari.org> wrote: > > Hi hackers, > > These two patches are split out from my earlier thread about improving > tab completion for varous RESET forms > (https://postgr.es/m/87bjqwwtic....@wibble.ilmari.org), so that the bug > fixes can be tracked as an open item for v18. > > Commits 9df8727c5067 and c407d5426b87 added tab completion for ALTER > DATABASE ... RESET and ALTER ROLE/USER ... RESET, respectively, but > they're both differently buggy. The query for the DATABASE form > neglected to schema-qualify the unnest() call, and the query for the > ROLE/USER form shows all possible variables once you start typing a > variable name, not just the ones that are set on the role. The attached > patches fix both. >
I played around with it, and overall it looks good.
