On 2025/07/19 15:45, vignesh C wrote:
Also, I don't see why there are three patches here instead of just one.
Earlier we thought to commit replication changes function firstlly and
then commit dblink and fdw changes, but now that we are using a common
notice receiver function. I feel it can be a single patch.
Yes, I initially suggested splitting the patches for that reason,
but I agree it's better to merge them into a single patch now that
we're using a shared custom notice receiver.
Merged the
patches. The attached v7 version patch has the changes for the same.
Thanks for updating the patch! It looks good to me, except for one minor point:
static inline PGresult *libpqsrv_get_result(PGconn *conn, uint32
wait_event_info);
+static inline void libpqsrv_notice_receiver(void *arg, const PGresult *res);
This prototype is only needed if the function is used earlier in
libpq-be-fe-helpers.h,
but that's not the case here, so I don't think it's necessary.
Unless there are objections, I'll remove that prototype and commit the patch.
Regards,
--
Fujii Masao
NTT DATA Japan Corporation
