Kwangwon Seo <anchovy...@gmail.com> writes: > Using the PostgreSQL code coverage report, I found that tests for > comparisons between date and timestamp[tz] are missing. Some of them have > only partial coverage. > Attached patch will cover following functions: > ...
I'm really not very excited about adding regression test cycles forevermore just to make these functions show as covered in the coverage report. They are all trivial wrappers around some "internal" comparison function, and IMO what's important to cover is that internal function. We don't necessarily need to check every one of the wrappers, so long as the internal function is fully exercised. There are other functions in these files that'd be more worthy of dedicated tests, because they are not just trivial wrappers around something else. For instance, it doesn't look like date_decrement, date_increment, date_skipsupport are reached at all. regards, tom lane