On Tue, Jul 15, 2025 at 2:10 PM jian he <jian.universal...@gmail.com> wrote: > > accidently found another existing bug. > > create schema test; > CREATE DOMAIN test.d1 AS integer NOT NULL default 11; > alter domain test.d1 add constraint a2 check(value > 1) not valid; > comment on CONSTRAINT a2 ON DOMAIN test.d1 is 'test'; > dump output is: > > CREATE SCHEMA test; > CREATE DOMAIN test.d1 AS integer NOT NULL DEFAULT 11; > COMMENT ON CONSTRAINT a2 ON DOMAIN test.d1 IS 'test'; > ALTER DOMAIN test.d1 > ADD CONSTRAINT a2 CHECK ((VALUE > 1)) NOT VALID; > > Obviously the COMMENT command will error out. > currently working on a fix, just sharing the bug details in advance.
we should let: dumpConstraint handles dumping separate "NOT VALID" domain constraints along with their comments. dumpDomain: handles dumping "inlined" valid (not separate) domain constraints together with their comments. tested locally, i didn't write the test on src/bin/pg_dump/t/002_pg_dump.pl.... v5-0001-fix-pg_dump-domain-not-valid-constraint-comments.no-cfbot was based on v4-0001-Improve-pg_dump-handling-of-domain-not-null-constraints.patch and 0001-fix-tweak.patch.txt.
v5-0001-fix-pg_dump-domain-not-valid-constraint-comments.no-cfbot
Description: Binary data
