On Wed, Jul 9, 2025 at 8:30 AM shveta malik <shveta.ma...@gmail.com> wrote:
> >
> > I have split your top up patch into 2 - one related to the document
> > change being the subject of this thread and the other for fixing the
> > query. Committer may squash the patch, if they think so.
> >
>
> The changes look good to me.
Thanks.
Looks like Amit has already committed it. I had created a CF entry
https://commitfest.postgresql.org/patch/5904/ to track this. I will
mark it as committed now.
Amit,
While reviewing the patches again, I felt that the second sentence in
that section also needs a bit of clarification. Here's patch with that
change. Please feel free to reject it or apply it.
--
Best Wishes,
Ashutosh Bapat
From 6e415d5c83d6f2cddfd7e81824997c99b2529c24 Mon Sep 17 00:00:00 2001
From: Ashutosh Bapat <ashutosh.bapat....@gmail.com>
Date: Wed, 9 Jul 2025 18:41:40 +0530
Subject: [PATCH] Some more clarifications for non-PG subscriptions
---
doc/src/sgml/logical-replication.sgml | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml
index e26f7f59d4a..01ef3d413d4 100644
--- a/doc/src/sgml/logical-replication.sgml
+++ b/doc/src/sgml/logical-replication.sgml
@@ -689,14 +689,15 @@ HINT: To initiate replication, you must manually create the replication slot, e
To allow subscriber nodes to continue replicating data from the publisher
node even when the publisher node goes down, there must be a physical standby
corresponding to the publisher node. The logical slots on the primary server
- corresponding to the subscriptions can be synchronized to the standby server by
- specifying <literal>failover = true</literal> when creating subscriptions. See
- <xref linkend="logicaldecoding-replication-slots-synchronization"/> for details.
- Enabling the
- <link linkend="sql-createsubscription-params-with-failover"><literal>failover</literal></link>
- parameter ensures a seamless transition of those subscriptions after the
- standby is promoted. They can continue subscribing to publications on the
- new primary server.
+ corresponding to the subscriptions can be synchronized to the standby server
+ by specifying <literal>failover = true</literal> when creating subscriptions
+ or when creating replication slots directly. See <link
+ linkend="sql-createsubscription"><command>CREATE
+ SUBSCRIPTION</command></link> and <xref
+ linkend="logicaldecoding-replication-slots-synchronization"/> for details.
+ This ensures a seamless transition of those subscriptions after the standby
+ is promoted. They can continue subscribing to publications on the new primary
+ server.
</para>
<para>
base-commit: f5a987c0e5f6bbf0cc0420228dc57e7aae4d7e8f
--
2.34.1
