Krasiyan, > Hi, > Patch applies and compiles, all included tests passed and performance gain > is really impressive. I have been using the latest versions for months with > real data and didn't find any bugs, so It is definitely ready for committer > status.
Thanks for testing the patch. The CF status has been already set to "ready for committer". I just changed the target version from 18 to 19. > I am not sure how the case where frame clause is "RANGE" or "GROUPS" > and frame end is "CURRENT ROW" is majority of window function use > cases. If it's majority, the optimization in v14 does not help much > because v14 does not optimize the case. However if it's not, the v14 > patch is close to commitable form, I think. Comments are welcome. Have you tested cases where the frame option is "RANGE" or "GROUPS" and the frame end is "CURRENT ROW"? I am asking because in these cases the optimization in the v14 (and v15) patches do not apply and you may not be satisfied by the performance. Best regards, -- Tatsuo Ishii SRA OSS K.K. English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp
