Fabien COELHO <coe...@cri.ensmp.fr> writes:
>> Right. As before, I'm not excited about rejecting trailing junk,
>> considering we never did before.
> My 0.02ยค: accepting trailing junk is just a recipee for hiding bugs:
> sh> psql "connect_timeout=2,port=5433"
> psql> \conninfo
> ... port=5432 # port directive was silently ignored
> So erroring out would be a good thing, and it could be done on a new
> release.
Perhaps. That should certainly be a separate patch, though, and
it should cover everything not just connection_timeout (I see at
least five parameters that are parsed with atoi() and nothing else).
I'm still not excited, but feel free to send a patch.
regards, tom lane
