>> It's a bit odd that we have both `VacuumParams *params` and >> `struct VacuumParams *params`.
Thanks for pointing that out, the attached new version fixed that. >> I'd suggest just marking the VacuumParams *params with const... I initially considered that approach. However, the current code path for vacuum_rel handles table option re-consolidation, rather than the ExecVacuum caller. This would require moving all parameter checks into ExecVacuum, which I'm not sure is ideal. For this patch, let's focus on resolving the inconsistent behavior. We can discuss parameter re-consolidation further in this thread: https://postgr.es/m/aFRxC1W_kZU9OjJ9%40nathan
vacuum_tables_options_5.patch
Description: Binary data
