On Sun, Aug 5, 2018 at 5:34 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Fri, Aug 3, 2018 at 2:09 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: >> On Thu, Aug 2, 2018 at 11:14 PM, Robert Haas <robertmh...@gmail.com> wrote: >>> In the third one, I don't think >>> "See ExecLimit" is a good thing to put a comment like this, because >>> it's too hard to find the comment to which it refers, and because >>> future commits are likely to edit or remove that comment without >>> noticing the references to it from elsewhere. Instead I would just >>> write, in all three places, /* If we know we won't need to back up, we >>> can release resources at this point. */ or something like that. >>> >> >> Okay, I have changed the comment as per your suggestion in the >> attached patch. I will do some more testing/verification of this >> patch and will commit over the weekend or on Monday if everything is >> fine. >> > > I have verified that the patch works whenever we use scrollable > cursors. Please find the attached patch with the modified commit > message. I think now it is a bit late for this minor-release and this > doesn't appear to be a blocker issue, it is better to push it after > the release. >
Pushed. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
