Re: Conflict detection for update_deleted in logical replication

[shveta malik]

On Mon, Jun 16, 2025 at 9:29 AM Zhijie Hou (Fujitsu)
<houzj.f...@fujitsu.com> wrote:
>
> 0001:
> * Removed the slot acquisition as suggested above.
>
> 0002:
> * Addressed the comments above.
>

Thanks for the patches.

In advance_conflict_slot_xmin(), if new_xmin is same as slot's current
 xmin, then shall we simply return without doing any slot- update?
Below assert indicates that new_xmin can be same as slot's current
xmin:
Assert(TransactionIdPrecedesOrEquals(MyReplicationSlot->data.xmin, new_xmin));

thanks
Shveta