On Thu, Jun 12, 2025 at 8:05 PM Fujii Masao <masao.fu...@oss.nttdata.com> wrote:
> On 2025/06/04 20:18, Fujii Masao wrote: > > > I've also re-attached the 0001 patch that makes \conninfo report the full > > protocol version, it's the same as the one I posted earlier in the > thread. > > The 0001 patch changes \conninfo to report the full protocol version > (e.g., 3.2) > instead of just the major version (e.g., 3). This is technically a > behavior change, > but since protocol version 3.2 was introduced in v18, and both 3.0 and 3.2 > are > now valid, always showing just "3" isn't very helpful. To see which > protocol > version is actually in use, showing the full version is more informative. > > Therefore I see this as fixing an oversight in commit bba2fbc6238, so I'd > like to > commit the 0001 patch as well in v18. Thought? > > You should get the concurrence of the RMT. But given that the output is new in v18 anyway my view is the original reworking of this view to be tabular just chose the wrong field to display and that needs to be fixed. Also, I was under the impression that updating relevant documentation for a feature wasn't even subject to RMT review; i.e., 0002 should go in too if it's otherwise committable. The feature it clarifies just changed/was added so having our best docs present at release should be a project goal. David J.
