On 21.02.25 19:19, Alvaro Herrera wrote:
I suggest the attached, which gets 99% there with 10% of the
complexity, and has \conninfo (no plus sign) output this:

              Connection Information
        Parámetro       │         Valor
───────────────────────┼────────────────────────
  Base de Datos         │ alvherre
  Client User           │ alvherre
  Host                  │ 192.168.178.37
  Port                  │ 55432
  Opciones              │
  Protocol Version      │ 3
  Password Used?        │ false
  GSSAPI Authenticated? │ false
  Backend PID           │ 1589499
  TLS Connection?       │ true
  TLS Library           │ OpenSSL
  TLS Protocol          │ TLSv1.3
  TLS Key Bits          │ 256
  TLS Cipher            │ TLS_AES_256_GCM_SHA384
  TLS Compression       │ false
  ALPN                  │ postgresql
  Superuser?            │ on
  Hot standby?          │ off
(18 filas)

This new code uses the term "TLS" where the rest of PostgreSQL, including the rest of psql, uses the term "SSL". Making this different seems uselessly confusing. I suggest the attached patch to use "SSL" here as well.
From 6a45955233f5c6737552494c85076850d5f3fe69 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut <pe...@eisentraut.org>
Date: Thu, 12 Jun 2025 16:19:48 +0200
Subject: [PATCH] psql: Change new \conninfo to use SSL instead of TLS

Commit bba2fbc6238 introduced a new implementation of the \conninfo
command in psql.  That new code uses the term "TLS" while the rest of
PostgreSQL, including the rest of psql, consistently uses "SSL".  This
is uselessly confusing.  This changes the new code to use "SSL" as
well.
---
 doc/src/sgml/ref/psql-ref.sgml |  2 +-
 src/bin/psql/command.c         | 16 ++++++++--------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/doc/src/sgml/ref/psql-ref.sgml b/doc/src/sgml/ref/psql-ref.sgml
index 8f7d8758ca0..cb8b4b0c1f8 100644
--- a/doc/src/sgml/ref/psql-ref.sgml
+++ b/doc/src/sgml/ref/psql-ref.sgml
@@ -1101,7 +1101,7 @@ <title>Meta-Commands</title>
         <listitem>
          <para>
           Outputs information about the current database connection,
-          including TLS-related information if TLS is in use.
+          including SSL-related information if SSL is in use.
          </para>
         </listitem>
       </varlistentry>
diff --git a/src/bin/psql/command.c b/src/bin/psql/command.c
index 81a5ba844ba..30b4d7eda45 100644
--- a/src/bin/psql/command.c
+++ b/src/bin/psql/command.c
@@ -874,11 +874,11 @@ exec_command_conninfo(PsqlScanState scan_state, bool 
active_branch)
        printTableAddCell(&cont, _("Backend PID"), false, false);
        printTableAddCell(&cont, backend_pid, false, false);
 
-       /* TLS Connection */
-       printTableAddCell(&cont, _("TLS Connection"), false, false);
+       /* SSL Connection */
+       printTableAddCell(&cont, _("SSL Connection"), false, false);
        printTableAddCell(&cont, ssl_in_use ? _("true") : _("false"), false, 
false);
 
-       /* TLS Information */
+       /* SSL Information */
        if (ssl_in_use)
        {
                char       *library,
@@ -895,19 +895,19 @@ exec_command_conninfo(PsqlScanState scan_state, bool 
active_branch)
                compression = (char *) PQsslAttribute(pset.db, "compression");
                alpn = (char *) PQsslAttribute(pset.db, "alpn");
 
-               printTableAddCell(&cont, _("TLS Library"), false, false);
+               printTableAddCell(&cont, _("SSL Library"), false, false);
                printTableAddCell(&cont, library ? library : _("unknown"), 
false, false);
 
-               printTableAddCell(&cont, _("TLS Protocol"), false, false);
+               printTableAddCell(&cont, _("SSL Protocol"), false, false);
                printTableAddCell(&cont, protocol ? protocol : _("unknown"), 
false, false);
 
-               printTableAddCell(&cont, _("TLS Key Bits"), false, false);
+               printTableAddCell(&cont, _("SSL Key Bits"), false, false);
                printTableAddCell(&cont, key_bits ? key_bits : _("unknown"), 
false, false);
 
-               printTableAddCell(&cont, _("TLS Cipher"), false, false);
+               printTableAddCell(&cont, _("SSL Cipher"), false, false);
                printTableAddCell(&cont, cipher ? cipher : _("unknown"), false, 
false);
 
-               printTableAddCell(&cont, _("TLS Compression"), false, false);
+               printTableAddCell(&cont, _("SSL Compression"), false, false);
                printTableAddCell(&cont, (compression && strcmp(compression, 
"off") != 0) ?
                                                  _("true") : _("false"), 
false, false);
 
-- 
2.49.0

Reply via email to