On Fri, May 23, 2025 at 09:54:54AM +0200, Álvaro Herrera wrote: > On 2025-May-20, Bruce Momjian wrote: > > > On Tue, May 20, 2025 at 05:15:54PM +0300, Nazir Bilal Yavuz wrote: > > > > As of the date of the commit, "Co-authored-by:" is listed as: > > > > > > > > https://wiki.postgresql.org/wiki/Commit_Message_Guidance > > > No problem. The "Co-authored-by:" guidance was only written down in > > January of this year. I assume Thomas Munro was following that guidance > > when he wrote the commit message. > > FWIW I have not taken to following that page yet, particularly because > the chosen page title is pretty random, there are no links to it, and I > couldn't find it when I searched for it; I wouldn't assume anyone is > using it as if it were already gospel. > > Anyway, in order to contribute I added a few links to it, and also fixed > the markup some.
Great, thanks. > TBH I don't agree with everything the page says. For instance, I don't > think we should care about what gitweb does with the commit title. > gitweb is a dying interface and we'd do good to get rid of it, relying > instead on cgit only. cgit shows more than 50 chars of the commit > title, so I don't think there's a reason to limit oneself to 50 chars > there. Agreed, gitweb limit removed. > I also think that showing an XML-ish format of a commit message is > unhelpful, not to mention hard to read. Showing a few actual examples > would be better. Agreed, but the XML came from Joe Conway so I am hesitant to remove it myself without feedback from him. -- Bruce Momjian <br...@momjian.us> https://momjian.us EDB https://enterprisedb.com Do not let urgent matters crowd out time for investment in the future.
