On Fri, May 9, 2025 at 5:09 AM Nisha Moond <nisha.moond...@gmail.com> wrote: > > On Thu, May 8, 2025 at 11:35 AM shveta malik <shveta.ma...@gmail.com> wrote: > > > > On Wed, May 7, 2025 at 4:36 PM Nisha Moond <nisha.moond...@gmail.com> wrote: > > > > > > > > > Attached is the v13 patch with the above comments addressed. > > > > > > -- > > > > Thanks for the patch. > > > > I think we can have the restriction mentioned under the 'two_phase' > > section as well along with the 'failover' section in the CREATE > > SUBSCRIPTION doc, similar to what we have in CREATE_REPLICATION_SLOT. > > > > Apart from this, I have no more comments. > > > > Thanks for the review. > Please find the v14 patch, updated with the above suggestion and > rephrased changes in alter_subscription.sgml with the missing links.
Thank you for updating the patch. I'm reviewing the v14 patch and will share some comments tomorrow. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
